Don't output errorneous proofs for invalid cell indices, return error… #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luka-ethernal
force-pushed
the
luka/dont-ignore-errors
branch
from
c2dffe6
to
aeedfe7
Compare
aterentic-ethernal
approved these changes
Aug 1, 2023
luka-ethernal
requested review from
markopoloparadox,
Leouarz,
momosh-ethernal and
sh3ll3x3c
Leouarz
approved these changes
Aug 2, 2023
I hate this sooo much. |
fmiguelgarcia
approved these changes
Aug 8, 2023
| @@ -376,7 +377,7 @@ pub fn build_proof<M: Metrics>( | |||
| for (cell, res) in cell_iter { | |||
| let r_index = usize::try_from(cell.row.0)?; | |||
| if r_index >= ext_rows || cell.col >= block_dims.cols { | |||
| res.fill(0); // for bad cell identifier, fill whole proof with zero bytes ! | |||
| return Err(Error::IndexOutOfRange); | |||
There was a problem hiding this comment.
Could we please use avail_core::ensure here? That could remove the if-else
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… instead.